Zipkin exporter: Serialize EventData attributes as JSON #4934
+105
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
changed the title
Codecov ReportBase: 91.00% // Head: 91.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4934 +/- ##
============================================
+ Coverage 91.00% 91.02% +0.01%
- Complexity 4839 4847 +8
============================================
Files 546 547 +1
Lines 14439 14455 +16
Branches 1395 1396 +1
============================================
+ Hits 13140 13157 +17
+ Misses 894 893 -1
Partials 405 405
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
reviewed
Nov 11, 2022
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Show resolved
Hide resolved
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Outdated
Show resolved
Hide resolved
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Outdated
Show resolved
Hide resolved
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 14, 2022
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Show resolved
Hide resolved
jack-berg
approved these changes
Nov 14, 2022
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
…ry#4934) * serialize EventData attributes to json * remove import * fix test * address code review comments. * safety first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4859.